[NETBEANS-4818] New Module system build-impl.xml doesn't work on windows

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 12.2
• Component/s: java - Compiler
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Austin Stephens
• Created: 18/Sep/20 20:44
• Updated: 05/Feb/21 20:57
• Resolved: 09/Oct/20 18:59

Description

To fix the issue of Nashorn being removed, someone is having ant compile scripts. They apparently did this without using an IDE since they are comparing strings with "==" and "!=", which is why it doesn't work on Windows. I have fixed it but am too lazy to check it in. Here is the new fixed method as it appears in build-impl.xml:

    private String toRegexp2(String spec, String filepattern, String separator) {
        List<String> prefixes = new ArrayList<>();
        List<String> suffixes = new ArrayList<>();
        pathVariants(spec).forEach(item -> {
            suffixes.add(item);
        });
        String tail = "";
        String separatorString = separator;
        if ("\\".equals(separatorString)) {
            separatorString = "\\\\";
        }
        if (filepattern != null && !filepattern.equals(tail)) {
            tail = separatorString + filepattern;
        }
        return "([^" + separatorString +"]+)\\Q" + separator + "\\E(" + suffixes.stream().collect(Collectors.joining("|")) + ")" + tail;
    }

Issue Links

• links to: GitHub Pull Request #2433