[NETBEANS-3695] not proper to use a static variable through a reference

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 11.3
• Labels: pull-request-available
• Assignee: Brad Walker
• Reporter: Brad Walker
• Created: 14/Jan/20 23:31
• Updated: 16/Jan/20 19:13
• Resolved: 16/Jan/20 19:13

Description

It's really not proper to use a static variable through a reference because they can't be derived. The proper thing to do is use them with a Class name..

   [repeat] /home/bwalker/src/netbeans/java/java.hints.ui/src/org/netbeans/modules/java/hints/spiimpl/refactoring/ConfigurationsComboModel.java:175: warning: [static] static variable should be qualified by type name, KeyEvent, instead of by an expression
   [repeat]             if (ke.getKeyCode() == ke.VK_ENTER || ke.getKeyCode() == ke.VK_ESCAPE) {
   [repeat]                                      ^
   [repeat] /home/bwalker/src/netbeans/java/java.hints.ui/src/org/netbeans/modules/java/hints/spiimpl/refactoring/ConfigurationsComboModel.java:175: warning: [static] static variable should be qualified by type name, KeyEvent, instead of by an expression
   [repeat]             if (ke.getKeyCode() == ke.VK_ENTER || ke.getKeyCode() == ke.VK_ESCAPE) {
   [repeat] 

^
This change fixes that..

Issue Links

• links to: GitHub Pull Request #1872