[NETBEANS-2783] Maven dependencies node does not show dependencies added editing POM

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 11.0, 11.1
• Fix Version/s: 11.2
• Component/s: projects - Generic Projects UI, projects - Maven
• Labels: pull-request-available regression

Environment

Product Version: Apache NetBeans IDE 11.1
Updates: Updates available
Java: 1.8.0_202; OpenJDK 64-Bit Server VM 25.202-b08
Runtime: OpenJDK Runtime Environment 1.8.0_202-b08
System: Windows 10 version 10.0 running on amd64; Cp1252; en_IE (nb)
User directory: C:\Users\falappa\AppData\Roaming\NetBeans\11.1
Cache directory: C:\Users\falappa\AppData\Local\NetBeans\Cache\11.1

• Assignee: Alessandro Falappa
• Reporter: Alessandro Falappa
• Created: 02/Jul/19 09:17
• Updated: 03/Nov/20 15:50
• Resolved: 26/Jul/19 09:07

Description

Steps:

1. Open or create a new maven project
2. Expand the Dependencies node in Projects view
3. Open pom.xml and add a dependency that has never been used before, i.e. is not in the local maven repository (.m2/repository)
4. Save pom.xml

Expected (works in NB 8.2): a jar entry with  the name of the dependency artifact appears under the Dependencies node of the project with a yellow triangle badge indicating new dependency detected but missing local copy.

Actual (broken in NB11.0 and NB11.1-beta2): no jar entry appears, the log contains the following warning (here for commons-math3 dependency):

// WARNING [org.netbeans.modules.maven.nodes.DependenciesNode]: Could not determine module name for artifact jar:file:/C:/Users/falappa/.m2/repository/org/apache/commons/commons-math3/3.6.1/commons-math3-3.6.1.jar!/

In NB11.0 and NB11.1-beta2 after rebuilding the project the dependencies node gets updated and a regular jar entry appears. In NB8.2 after rebuilding the project the yellow triangle badge disappears.

I had a look at the code and it looks like something got broken when adding modular Java support, i.e. in NB 9.0, as the code is trying to determine Java module names for each dependency.

This is a regression, NetBeans 8.2 works, NetBeans 11.0 and NetBeans 11.1-beta2 do not, NetBeans 9.0 and 10.0 not tested.

 

Issue Links

• duplicates: NETBEANS-572 non existing dependencies are not shown under the Dependencies node
• links to: GitHub Pull Request #1367