[NETBEANS-2565] NB-based application fails to verify NB plugin signatures

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 11.0
• Fix Version/s: Next
• Component/s: updatecenters - Pluginportal
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Svatopluk Dedic
• Created: 20/May/19 16:55
• Updated: 03/Nov/20 15:49
• Resolved: 30/May/19 13:54

Description

I have a NB platform app application, which includes updatecenters module from the nb cluster.  

I am now trying to upgrade to NB11 and it seems that the file nb/core/ide.ks file is not copied to the application distribution.

Steps to reproduce:

1. Create NB Platform Application project
2. include Update Centers module from nb cluster
3. Build
4. Package as > ZIP
5. unzip the zipfile

There's no ide.ks file.

Effects:

1. When run with assertion disabled, all modules downloaded from NB update center or plugin portal appear unsigned
2. When run with assertions enabled, the following assertion is thrown / displayed as error dialog:

java.lang.AssertionError: File found at core/ide.ks 
        at org.netbeans.modules.updatecenters.resources.NetBeansKeyStoreProvider.getKeyStoreFile(NetBeansKeyStoreProvider.java:48) 
        at org.netbeans.modules.updatecenters.resources.NetBeansKeyStoreProvider.getKeyStore(NetBeansKeyStoreProvider.java:43) 
        at org.netbeans.modules.autoupdate.services.Utilities.getKeyStore(Utilities.java:121) 
        at org.netbeans.modules.autoupdate.services.InstallSupportImpl.verifyNbm(InstallSupportImpl.java:1056) 
        at org.netbeans.modules.autoupdate.services.InstallSupportImpl.doValidate(InstallSupportImpl.java:847) 
        at org.netbeans.modules.autoupdate.services.InstallSupportImpl.doValidate(InstallSupportImpl.java:800) 
        at org.netbeans.modules.autoupdate.services.InstallSupportImpl.access$900(InstallSupportImpl.java:73) 
        at org.netbeans.modules.autoupdate.services.InstallSupportImpl$2.call(InstallSupportImpl.java:245) 
        at org.netbeans.modules.autoupdate.services.InstallSupportImpl$2.call(InstallSupportImpl.java:218) 
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)

Issue Links

• links to: GitHub Pull Request #1259