Details

    Description

      The issue tag should allow to reference PRs in (incubator-)netbeans githiub and possibly also Apache JIRA issues.

      Attachments

        Activity

          lkishalmi Laszlo Kishalmi made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          Closed as the issue has been resolved more than 180 days.

          lkishalmi Laszlo Kishalmi added a comment - Closed as the issue has been resolved more than 180 days.
          lkishalmi Laszlo Kishalmi made changes -
          Fix Version/s 9.0 [ 12340951 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]

          Marked as resolved as the corresponding PR has been merged.

          lkishalmi Laszlo Kishalmi added a comment - Marked as resolved as the corresponding PR has been merged.
          githubbot ASF GitHub Bot made changes -
          Worklog Id 63511 [ 63511 ]
          Time Spent 10m [ 600 ] 20m [ 1200 ]
          githubbot ASF GitHub Bot logged work - 26/Dec/17 20:03
          • Time Spent:
            10m
             
            matthiasblaesing closed pull request #309: NETBEANS-192 support jira issue in apichanges
            URL: https://github.com/apache/incubator-netbeans/pull/309
             
             
               

            This is a PR merged from a forked repository.
            As GitHub hides the original diff on merge, it is displayed below for
            the sake of provenance:

            As this is a foreign pull request (from a fork), the diff is supplied
            below (as it won't show otherwise due to GitHub magic):

            diff --git a/nbbuild/javadoctools/apichanges.xsl b/nbbuild/javadoctools/apichanges.xsl
            index 9b5611206..709e39dd6 100644
            --- a/nbbuild/javadoctools/apichanges.xsl
            +++ b/nbbuild/javadoctools/apichanges.xsl
            @@ -66,6 +66,7 @@ committed to the repository for legal reasons. You need to download it:
             
                 <!-- Overridable parameters: -->
                 <xsl:param name="issue-url-base" select="'https://netbeans.org/bugzilla/show_bug.cgi?id=&#39;"/>
            + <xsl:param name="apache-issue-url-base" select="'https://issues.apache.org/jira/browse/&#39;"/>
                 <xsl:param name="javadoc-url-base" select="'???'"/>
             
                 <!-- Main document structure: -->
            @@ -482,8 +483,14 @@ committed to the repository for legal reasons. You need to download it:
             
                 <xsl:template match="issue">
                     <a>
            - <xsl:attribute name="href"><xsl:value-of select="$issue-url-base"/><xsl:value-of select="@number"/></xsl:attribute>
            + <xsl:if test="contains(@number, 'NETBEANS')">
            + <xsl:attribute name="href"><xsl:value-of select="$apache-issue-url-base"/><xsl:value-of select="@number"/></xsl:attribute>
            + <xsl:value-of select="@number"/>
            + </xsl:if>
            + <xsl:if test="not(contains(@number, 'NETBEANS'))">
            + <xsl:attribute name="href"><xsl:value-of select="$issue-url-base"/><xsl:value-of select="@number"/></xsl:attribute>
                         #<xsl:value-of select="@number"/>
            + </xsl:if>
                     </a>
                 </xsl:template>
             


             

            ----------------------------------------------------------------
            This is an automated message from the Apache Git Service.
            To respond to the message, please log on GitHub and use the
            URL above to go to the specific comment.
             
            For queries about this service, please contact Infrastructure at:
            users@infra.apache.org
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #309 (Web Link)" [ 98400 ] This issue links to "GitHub Pull Request #309 (Web Link)" [ 98400 ]
          githubbot ASF GitHub Bot made changes -
          Worklog Id 63510 [ 63510 ]
          Remaining Estimate 0h [ 0 ]
          Time Spent 10m [ 600 ]
          githubbot ASF GitHub Bot logged work - 26/Dec/17 20:03
          • Time Spent:
            10m
             
            matthiasblaesing commented on issue #309: NETBEANS-192 support jira issue in apichanges
            URL: https://github.com/apache/incubator-netbeans/pull/309#issuecomment-354007639
             
             
               I agree with @lbruun assessment. With my nitpicking head on I'd have choosen "starts-with" instead of "contains", but for the current usecase (differ between bugzilla and jira) this should work fine.
               
               Thanks!

            ----------------------------------------------------------------
            This is an automated message from the Apache Git Service.
            To respond to the message, please log on GitHub and use the
            URL above to go to the specific comment.
             
            For queries about this service, please contact Infrastructure at:
            users@infra.apache.org
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #309 (Web Link)" [ 98400 ] This issue links to "GitHub Pull Request #309 (Web Link)" [ 98400 ]
          githubbot ASF GitHub Bot added a comment -

          lbruun commented on issue #309: NETBEANS-192 support jira issue in apichanges
          URL: https://github.com/apache/incubator-netbeans/pull/309#issuecomment-348627390

          Looks good. đź‘Ť

          To document what is going on:

          When you refer to an issue in `apichanges.xml` document, as in:

          <issue number="....."/>

          the number attribute can now be either a plain number (as before), e.g.

          `<issue number="23455"/>`

          in which case it will link to a Bugzilla issue, or if it looks like this:

          `<issue number="NETBEANS-243"/>`

          it will link to an Apache JIRA issue.

          ----------------------------------------------------------------
          This is an automated message from the Apache Git Service.
          To respond to the message, please log on GitHub and use the
          URL above to go to the specific comment.

          For queries about this service, please contact Infrastructure at:
          users@infra.apache.org

          githubbot ASF GitHub Bot added a comment - lbruun commented on issue #309: NETBEANS-192 support jira issue in apichanges URL: https://github.com/apache/incubator-netbeans/pull/309#issuecomment-348627390 Looks good. đź‘Ť To document what is going on: When you refer to an issue in `apichanges.xml` document, as in: <issue number="....."/> the number attribute can now be either a plain number (as before), e.g. `<issue number="23455"/>` in which case it will link to a Bugzilla issue, or if it looks like this: `<issue number=" NETBEANS-243 "/>` it will link to an Apache JIRA issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #309 (Web Link)" [ 98400 ] This issue links to "GitHub Pull Request #309 (Web Link)" [ 98400 ]
          githubbot ASF GitHub Bot added a comment -

          ebarboni opened a new pull request #309: NETBEANS-192 support jira issue in apichanges
          URL: https://github.com/apache/incubator-netbeans/pull/309

          This PR add a possibility to link apichanges issue to Apache JIRA instance.

          Assuming that jira instance for NetBeans will contains NETBEANS to check for difference with bugzilla issues.

          if former issues are migrated to Apache JIRA the triage must be removed.

          ----------------------------------------------------------------
          This is an automated message from the Apache Git Service.
          To respond to the message, please log on GitHub and use the
          URL above to go to the specific comment.

          For queries about this service, please contact Infrastructure at:
          users@infra.apache.org

          githubbot ASF GitHub Bot added a comment - ebarboni opened a new pull request #309: NETBEANS-192 support jira issue in apichanges URL: https://github.com/apache/incubator-netbeans/pull/309 This PR add a possibility to link apichanges issue to Apache JIRA instance. Assuming that jira instance for NetBeans will contains NETBEANS to check for difference with bugzilla issues. if former issues are migrated to Apache JIRA the triage must be removed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org
          githubbot ASF GitHub Bot made changes -
          Labels pull-request-available
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #309 (Web Link)" [ 98400 ]
          neilcsmith Neil C Smith added a comment -

          Contributor will use PR but for commiter they may direct push to git with no PR

          Well, some of us are arguing that shouldn't be the case!

          But, I concur we shouldn't be referencing GitHub for anything canonical - GitHub is just a mirror to what happens here. References to (merge) commits might be useful? But also cart before horse?

          neilcsmith Neil C Smith added a comment - Contributor will use PR but for commiter they may direct push to git with no PR Well, some of us are arguing that shouldn't be the case! But, I concur we shouldn't be referencing GitHub for anything canonical - GitHub is just a mirror to what happens here. References to (merge) commits might be useful? But also cart before horse?
          skygo Eric Barboni added a comment -

          I'm not sure PR are canonical enough to be linked in apichanges. Contributor will use PR but for commiter they may direct push to git with no PR.

          I think JIRA is the most important item.

          skygo Eric Barboni added a comment - I'm not sure PR are canonical enough to be linked in apichanges. Contributor will use PR but for commiter they may direct push to git with no PR. I think JIRA is the most important item.
          sdedic Svatopluk Dedic made changes -
          Field Original Value New Value
          Priority Major [ 3 ] Minor [ 4 ]
          sdedic Svatopluk Dedic created issue -

          People

            Unassigned Unassigned
            sdedic Svatopluk Dedic
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Slack

                  Issue deployment