[NETBEANS-1781] can't open classes in binary .jar (java.lang.ClassCastException: com.sun.tools.javac.code.Type$ClassType cannot be cast to com.sun.tools.javac.code.Type$ErrorType)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 10.0
• Component/s: java - Source
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Jeffrey Morlan
• Created: 06/Dec/18 05:25
• Updated: 02/Dec/19 19:46
• Resolved: 02/Dec/19 19:46

Description

After updating to nb-javac 1.51, when I try to open a class in a binary .jar file, it often fails with an exception like this

java.lang.ClassCastException: com.sun.tools.javac.code.Type$ClassType cannot be cast to com.sun.tools.javac.code.Type$ErrorType
    at org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:797)
    at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1083)
    at org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.visitExecutable(CodeGenerator.java:549)
    ...

This happens whenever the class references a class in a different .jar. For example, create a maven project, add org.apache.httpcomponents:httpclient (but don't download source!) and open the HttpClient class - it fails because of the various classes referenced from the httpcore dependency.

It looks like this started once http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20 was merged into nb-javac - TreeFactory's assumption that getKind()==ERROR implies ErrorType is no longer true.

Issue Links

• duplicates: NETBEANS-2392 Opening type from Go To Type fails
• relates to: NETBEANS-2116 Sometimes classes are not opened from "Go to type"
• links to: GitHub Pull Request #1084
• links to: GitHub Pull Request #1084