[NETBEANS-1663] JUnit 5 run single test does not work for @ParameterizedTest, and go to source from test results doesn't work for these tests

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.0
• Fix Version/s: 11.0
• Component/s: java - JUnit
• Labels: 11.0-vc1 pull-request-available
• Assignee: Stig Rohde Døssing
• Reporter: Stig Rohde Døssing
• Created: 12/Nov/18 14:36
• Updated: 03/Nov/19 20:11
• Resolved: 10/Feb/19 14:58

Description

In https://issues.apache.org/jira/browse/NETBEANS-6 some code was added that decides whether a code is a JUnit 5 test or not, by whether its annotation has @Testable
as a "parent" (for lack of a better term). This is too conservative, @Testable is a meta-annotation and can appear anywhere in the parent hierarchy for test method annotations. For example, @ParameterizedTest has @TestTemplate as a parent, which has @Testable as a parent.

The code should be updated to look through the entire annotation hierarchy to figure out if @Testable appears as a parent.

Also when a @ParameterizedTest is run, and the test results window is used to go to the test method, the IDE throws an exception. This happens because the test name of a parameterized test is e.g. "myMethod

{myParamType}

[0]", rather than just "myMethod". The lookup code assumes that the test name will appear verbatim in the source.

I think it makes sense to differentiate between the display name of a test method, and the actual method name. Adjusting org.netbeans.modules.gsf.testrunner.api.Testcase to allow this would let us fix this issue, while also making it easier to implement support for e.g. https://junit.org/junit5/docs/5.0.3/api/org/junit/jupiter/api/DisplayName.html at a later date.

Issue Links

• blocks: NETBEANS-1744 Support Run/Debug Focused Test Method for @Nested JUnit 5 test classes in Maven projects
• links to: GitHub Pull Request #1019