[NET-726] Add protected getters to FTPSClient

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.11.0
• Assignee: Unassigned
• Reporter: PJ Fanning
• Created: 09/Jan/24 10:30
• Updated: 10/Jan/24 14:18
• Resolved: 10/Jan/24 14:18

Description

As part of https://github.com/apache/incubator-pekko-connectors/pull/171, I am trying to subclass FTPSClient to revert the changes in NET-642 (see NET-718).

While the method that I need to change is protected, the method needs access to private fields.

The line I want to revert in the Apache Pekko code is https://github.com/apache/commons-net/pull/90/files#diff-b4292a5bd3e39f502d24bce1eb934384a951a120080c870cdc68c0585a78c6e9R269

That openDataConnection method uses a number of private final fields. Even if these fields were provided with protected getter methods, I would be able to access the values in my subclass.

For now, I've done a full copy of FTPSClient and adjusted that - but that is a lot of code to keep forked.

Issue Links

• relates to: NET-718 "Unsupported or unrecognized SSL message" for FTPS via proxy
• relates to: NET-642 FTPSClient execPROT removes proxy settings
• links to: GitHub Pull Request #204