[NET-622] SubnetInfo#getCidrSignature - improve functions

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.7
• Assignee: Unassigned
• Reporter: Makoto Sakaguchi
• Created: 04/Mar/17 09:49
• Updated: 06/Aug/20 12:27
• Resolved: 11/Mar/17 12:56

Description

The processing part of "netmask" is converted an integer to a string to an integer.

/* SubnetUtils.SubnetInfo#getCidrSignature() */
// a binary mask address
int netmask = 0b11111111000000000000000000000000;

// convert to a dotted decimal address
String maskStr = format(toArray(netmask)); // maskStr: "255.0.0.0"

/* SubnetUtils#toCidrNotation() */
// counting the 1-bit population
int cidr = pop(toInteger(maskStr)); // cidr: 8

So, I suggest to create CIDR from the netmask variable.
https://github.com/apache/commons-net/pull/10