[NET-594] TelnetClient._closeOutputStream unhandled exception from FilterOutputStream.close

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4
• Fix Version/s: 3.6
• Component/s: Telnet

Environment

Windows 7 64bit

• Assignee: Unassigned
• Reporter: Brad Worrall
• Created: 08/Jun/16 18:43
• Updated: 14/Feb/17 22:22
• Resolved: 07/Feb/17 23:54

Description

As part of fixing an existing bug Oracle introduced a new bug into FilterOutputStream.close:

http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8054565

While the bug is marked as fixed the fix will not be available until Java 9 from what I can tell and is not in the latest release as of writing (1.8.91)

This bug can also be reproduced through remote socket closure.

Due to this bug the TelnetClient when calling disconnect() throws an unhandled exception and is unable to close the connection, if the socket was remotely closed.

Stack Trace:

java.net.SocketException: Socket closed
at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:121)
at java.net.SocketOutputStream.write(SocketOutputStream.java:147)
at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
at java.io.FilterOutputStream.close(FilterOutputStream.java:159)
at org.apache.commons.net.telnet.TelnetClient._closeOutputStream(TelnetClient.java:86)
at org.apache.commons.net.telnet.TelnetOutputStream.close(TelnetOutputStream.java:155)
at org.apache.commons.net.telnet.TelnetClient.disconnect(TelnetClient.java:127)