[NET-583] FTPClient.getReplyString() returns wrong value after connect()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3
• Fix Version/s: 3.5
• Component/s: FTP
• Flags: Patch
• Assignee: Unassigned
• Reporter: Holger Rehn
• Created: 27/Nov/15 09:17
• Updated: 05/May/16 00:53
• Resolved: 15/Apr/16 19:08

Description

If the FTPClient's automatic server encoding detection is enabled, a FEAT command is issued in method connectAction() [indirectly via hasFeature(String)]. After that, the replyCode and _replyLines fields are stored back to their previous values in _connectAction(), but the _newReplyString flag isn't set to true. Because of that, you will then get back the reply to the FEAT command from getReplyString(), instead of the server's welcome message. Furthermore, you may get back a reply code that doesn't match that reply string. We have encountered a case when we got back reply code 220 after FTPClient.connect(), but reply string was "530 Not logged in.".

This error can easily be fixed by adding the following line to FTPClient.java around line 944:
_newReplyString = true;

Patch:
===================================================================
— src/org/apache/commons/net/ftp/FTPClient.java
+++ src/org/apache/commons/net/ftp/FTPClient.java (working copy)
@@ -941,6 +941,7 @@
_replyLines.clear();
_replyLines.addAll(oldReplyLines);
_replyCode = oldReplyCode;
+ _newReplyString = true;
}
}