Uploaded image for project: 'Commons Net'
  1. Commons Net
  2. NET-534

Unnecesssary call to getReplyString() if no listeners configured

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 3.4
    • Component/s: IMAP
    • Labels:
      None

      Description

      IMAP methods can return large amounts of data.

      The IMap.__getReply() method collects all the reply lines in a list which is converted to a string before being passed to SocketClient#fireReplyReceived(int, String).

      If there are no listeners, the string conversion is unnecessary, and could be very expensive.

      The fireReplyReceived method could be overridden to avoid this.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sebb@apache.org Sebb
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: