[NET-534] Unnecesssary call to getReplyString() if no listeners configured

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3
• Fix Version/s: 3.4
• Component/s: IMAP
• Assignee: Unassigned
• Reporter: Sebb
• Created: 09/Apr/14 22:25
• Updated: 26/Nov/15 16:34
• Resolved: 09/Apr/14 23:21

Description

IMAP methods can return large amounts of data.

The IMap.__getReply() method collects all the reply lines in a list which is converted to a string before being passed to SocketClient#fireReplyReceived(int, String).

If there are no listeners, the string conversion is unnecessary, and could be very expensive.

The fireReplyReceived method could be overridden to avoid this.