[NET-462] FTPClient in PASSIVE_LOCAL_DATA_CONNECTION_MODE cannot work when host have several different IP

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1
• Fix Version/s: 3.2
• Component/s: FTP
• Labels: ActiveIp FTPClient PASSIVE_LOCAL_DATA_CONNECTION_MODE

Environment

All OS,for example linux or windows and so on

• Assignee: Unassigned
• Reporter: Junsheng Chen
• Created: 24/Apr/12 08:16
• Updated: 17/Apr/13 19:57
• Resolved: 11/Jul/12 00:18

Description

When host have several different IP and client setting to PASSIVE_LOCAL_DATA_CONNECTION_MODE，openDataConnection creating socket may use the unexpected ip。
For example, The host have two Ips, one for intra and the another for extern, only the extern one can be connect with the outside。But when in PASSIVE_LOCAL_DATA_CONNECTION_MODE, FTPClient may be select the intra Ip, So it didn't work。
So I change code like this, it can work normally by the specific ip.
Code:
In FTPClient.openDataConnection(String command, String arg)，line 761 change as bellow:
socket = socketFactory.createSocket();

// add begin
// local as client, transfer data must use the appointed local host
socket.bind(new InetSocketAddress(getHostAddress(), 0));
// add end

After log in success,User can set the ip which he want to use by call the method in FTPClient:
setActiveExternalIPAddress(String ip);