Commons Net
  1. Commons Net
  2. NET-456

[net] TelnetClient hangs when reader-thread startup delays

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.2
    • Component/s: Telnet
    • Labels:
      None

      Description

      I'm trying to use TelnetClient(commons-net-3.1) with the reader-thread enabled,
      but it sometimes hangs.

      I tracked "__receiveState", and found that the state sometimes changes to invalid ones.

      In threaded-mode, TelnetInputStream.__read(boolean mayBlock) is normally called only by TelnetInputStream.run().
      But if the read-thread startup delays, it may also called by TelnetInputStream.read()
      beacues the value of __threaded is still false.

      example of hang-up pattern

      1.
      // user-thread
      telnetClient._connectAction()
      TelnetInputStream._start()
      __thread.start(); ... try to start read-thread

      2.
      // user-thread
      TelnetInputStream.read() ... _threaded is still false, so TelnetInputStream._read() is called.

      3.
      // read-thread starts (before __read() above dosen't end )
      TelnetInputStream.run( ) ... sets _threaded to true, and calls TelnetInputStream._read()

      I think __threaded flag should be set to true just after __thread.start(),
      not at the begining of run().

      __thread.start();
      __threaded = true; // add

      This problem may related to NET-73

        Activity

        Hide
        Sebb added a comment -

        URL: http://svn.apache.org/viewvc?rev=1361549&view=rev
        Log:
        NET-456 TelnetClient hangs when reader-thread startup is delayed.

        Modified:
        commons/proper/net/trunk/src/changes/changes.xml
        commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java

        Show
        Sebb added a comment - URL: http://svn.apache.org/viewvc?rev=1361549&view=rev Log: NET-456 TelnetClient hangs when reader-thread startup is delayed. Modified: commons/proper/net/trunk/src/changes/changes.xml commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java

          People

          • Assignee:
            Unassigned
            Reporter:
            MarikoSekiguchi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development