[NET-442] StringIndexOutOfBoundsException: String index out of range: -1 if server respond with root is current directory

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.1
• Fix Version/s: 3.2
• Component/s: FTP

Environment

Ubuntu linux 11.04

• Assignee: Unassigned
• Reporter: Andrea Selva
• Created: 15/Feb/12 08:08
• Updated: 17/Apr/13 19:57
• Resolved: 02/Mar/12 19:48

Description

I've an ftp server that at the pwd request responds with |257 root is current directory.| without any double quotes present and the lib gives up with this exception:

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.substring(String.java:1949)
at org.apache.commons.net.ftp.FTPClient.__parsePathname(FTPClient.java:469)
at org.apache.commons.net.ftp.FTPClient.printWorkingDirectory(FTPClient.java:2374)

Probably it's only needed a check in __parsePathname

private String __parsePathname(String reply)
{
int begin, end;

begin = reply.indexOf('"') + 1;
end = reply.indexOf('"', begin);

if (begin == -1 && end == -1)

{ return reply; }

return reply.substring(begin, end);
}