Commons Net
  1. Commons Net
  2. NET-425

_openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.1
    • Fix Version/s: 3.1
    • Component/s: FTP
    • Labels:
      None
    • Environment:

      All

      Description

      Currently _storeFile, __storeStream, and _openConnection are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.

      1. patch.txt
        3 kB
        Steven Jardine
      2. retrievefile.patch
        6 kB
        Steven Jardine

        Activity

        Steven Jardine created issue -
        Hide
        Steven Jardine added a comment -

        Please consider the attached patch for inclusion in the project.

        Show
        Steven Jardine added a comment - Please consider the attached patch for inclusion in the project.
        Steven Jardine made changes -
        Field Original Value New Value
        Attachment patch.txt [ 12497578 ]
        Hide
        Sebb added a comment -

        Do you really require access to both the String and int versions of the methods?

        Show
        Sebb added a comment - Do you really require access to both the String and int versions of the methods?
        Hide
        Steven Jardine added a comment -

        I only use the String methods. I guess you could leave the int methods private but I really don't see why private access is required for these methods.

        Show
        Steven Jardine added a comment - I only use the String methods. I guess you could leave the int methods private but I really don't see why private access is required for these methods.
        Sebb made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sebb made changes -
        Fix Version/s 3.1 [ 12317744 ]
        Affects Version/s 3.0.1 [ 12316459 ]
        Hide
        Steven Jardine added a comment -

        While implementing my client I noticed a similiar problem with the receiveFile and receiveFileStream methods.

        I have implemented __receiveFile, _receiveFile, __receiveFileStream, _receiveFileStream similiar to the __storeFile methods and modified the receiveFile and receiveFileStream methods to use these.

        Please consider my patch for inclusion.

        Show
        Steven Jardine added a comment - While implementing my client I noticed a similiar problem with the receiveFile and receiveFileStream methods. I have implemented __receiveFile, _receiveFile, __receiveFileStream, _receiveFileStream similiar to the __storeFile methods and modified the receiveFile and receiveFileStream methods to use these. Please consider my patch for inclusion.
        Steven Jardine made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Steven Jardine made changes -
        Attachment retrievefile.patch [ 12502514 ]
        Steven Jardine made changes -
        Attachment retrievefile.patch [ 12502514 ]
        Hide
        Steven Jardine added a comment -

        Fixed a bug with the patch.

        Show
        Steven Jardine added a comment - Fixed a bug with the patch.
        Steven Jardine made changes -
        Attachment retrievefile.patch [ 12503423 ]
        Hide
        Sebb added a comment -

        Thanks.

        I modified the patch slightly; got rid of the private methods (only used once) and rearranged the methods to simplify the difference between versions.

        Show
        Sebb added a comment - Thanks. I modified the patch slightly; got rid of the private methods (only used once) and rearranged the methods to simplify the difference between versions.
        Sebb made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sebb made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        28d 14h 56m 1 Sebb 01/Nov/11 15:28
        Resolved Resolved Reopened Reopened
        3d 4h 20m 1 Steven Jardine 04/Nov/11 19:48
        Reopened Reopened Resolved Resolved
        7d 5h 25m 1 Sebb 12/Nov/11 01:13
        Resolved Resolved Closed Closed
        109d 19h 22m 1 Sebb 29/Feb/12 20:35

          People

          • Assignee:
            Unassigned
            Reporter:
            Steven Jardine
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development