Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: None
    • Labels:
      None

      Description

      Should the sendCommandWithID() methods be public?

      These allow the user to override the tag generation, or even send invalid tags.

      I think it would be better to reserve these for internal use.

      If a use case for them is found later, the visibility can be changed back.
      But reducing visibility breaks binary compatibility - best to start with minimal visibility (and mutabiliy) and relax as necessary later.

        Activity

        Hide
        sebb@apache.org Sebb added a comment -

        Note that users can override the protected generateCommandId() method if they wish to change the tag format

        Show
        sebb@apache.org Sebb added a comment - Note that users can override the protected generateCommandId() method if they wish to change the tag format
        Hide
        dfs@apache.org Daniel Savarese added a comment -

        sendCommandWithID being public is consistent with the original design intent for base protocol classes. Why are you not discussing these issues on the development mailing list first?

        Show
        dfs@apache.org Daniel Savarese added a comment - sendCommandWithID being public is consistent with the original design intent for base protocol classes. Why are you not discussing these issues on the development mailing list first?

          People

          • Assignee:
            Unassigned
            Reporter:
            sebb@apache.org Sebb
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development