Uploaded image for project: 'Commons Net'
  1. Commons Net
  2. NET-381

Parsing is inefficient, as it parses everything twice

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: FTP
    • Labels:
      None

      Description

      The default preParse() method - FTPFileEntryParserImpl.preParse() - parses every entry, and removes any that do not parse.

      The entries are later parsed again to produce the main output.

      It would be more efficient to weed out null entries once after parsing.

      The preParse() method should be reserved for cases where it is strictly necessary, e.g. VMSVersioningFTPEntryParser and MVSFTPEntryParser which already override the default implementation.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sebb@apache.org Sebb
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: