Uploaded image for project: 'Commons Net'
  1. Commons Net
  2. NET-374

ParserInitializationException doesn't use standard JDK exception chaining

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 3.0
    • Component/s: FTP
    • Labels:
      None

      Description

      ParserInitializationException appears to have its own rootCause instance variable, rather than using RuntimeException's constructors which allow a cause to be specified (ParserInitializationException extends RuntimeException). So for example on line 53 of this class [1], I would expect to see a simple invocation to super(message, rootCause).

      The reason this has come up is that we're logging these exceptions using log4j, but because ParserInitializationException doesn't use the standard JDK exception chaining, we don't get visibility into the root issue in the logs.

      This was discussed briefly on the user mailing list [2].

      [1] http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/ParserInitializationException.java?view=markup
      [2] http://markmail.org/thread/6hn3doow352ic6ho

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sdanig Daniel Gredler
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: