Commons Net
  1. Commons Net
  2. NET-338

ftp.FTPClient.initiateListParsing(String parserKey, String pathname) can call createFileEntryParser with null systemName

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2
    • Component/s: FTP
    • Labels:
      None

      Description

      ftp.FTPClient.initiateListParsing(String parserKey, String pathname) can call createFileEntryParser(String) with null systemName if the getSystemName() method fails.

      The resulting ParserInitializationException does not identify the cause.

      It would be better to throw a more specific error if the system name cannot be found.

      Ideally, getSystemName() should throw the error, but that would change the documented behaviour (null is specifically allowed as a return value).

      As it happens, getSystemName() is badly named, so one way forward is to create a new method getSystemType() which never returns null.

      Can then deprecate getSystemName().

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        158d 11h 13m 1 Sebb 26/Feb/11 02:59
        Resolved Resolved Closed Closed
        98d 16h 25m 1 Sebb 04/Jun/11 19:25
        Sebb made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Sebb made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.2 [ 12315361 ]
        Resolution Fixed [ 1 ]
        Sebb made changes -
        Component/s FTP [ 12313626 ]
        Sebb made changes -
        Field Original Value New Value
        Project Commons VFS [ 12310495 ] Commons Net [ 12310487 ]
        Key VFS-318 NET-338
        Sebb created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Sebb
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development