Uploaded image for project: 'Commons Net'
  1. Commons Net
  2. NET-328

FromNetASCIIInputStream.read(byte[], int, int) may change length passed to superclass if not doing conversion

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.2
    • Component/s: None
    • Labels:
      None

      Description

      The method FromNetASCIIInputStream.read(byte[], int, int) may change the length passed to superclass if not doing conversion.

      It should probably check _noConversionRequired and call the super-class before recalculating the length.
      That is

      if (_noConversionRequired)
          return super.read(buffer, offset, __length);
      

      should be done at the very start of the method.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sebb@apache.org Sebb
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: