what my patch does:
- (re)enable EPSV command on IPv4 too (i dont know why Rory Winston removed it from the supplied patch in
NET-288), also see my comments in patch
- sending EPRT only if we are over IPv6, cause there is no advantage over PORT on IPv4, it could even have disadvantages (see comments in patch)
- EPRT was sending the result of getActivePort() to the server, but when there was no activePortRange set, it did send 0 as default which leads to an error on server site:
Tue Mar 23 17:17:20 2010 [pid 10581] [ftpuser] FTP command: Client "192.168.11.130", "EPRT |1|192.168.11.130|0|"
Tue Mar 23 17:17:20 2010 [pid 10581] [ftpuser] FTP response: Client "192.168.11.130", "500 Illegal EPRT command."
- and even calling getActivePort() has no sense here, cause that port is used to be random, but we should send same port where the ServerSocket is listening on -> server.getLocalPort()
- getActivePort() checks if __activeMaxPort > __activeMinPort, but when i want to set a range of only one single port (min==max) it would return 0 ... now it will check if equal and return __activeMaxPort