Uploaded image for project: 'Commons Net'
  1. Commons Net
  2. NET-289

StackOverflowError in Threader

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 3.0
    • NNTP
    • None

    Description

      The loop detection code in Threader.buildContainer() is currently:
      // Link references together in the order they appear in the References: header,
      // IF they dont have a have a parent already &&
      // IF it will not cause a circular reference
      if ((parentRef != null)
      && (ref.parent == null)
      && (parentRef != ref)
      && !(parentRef.findChild(ref))) {
      // Link ref into the parent's child list
      Deep circular references where 'parentRef' is already a child of 'ref' and ref is the root container are possible.
      The test should be:
      if ((parentRef != null)
      && (ref.parent == null)
      && (parentRef != ref)
      && !(ref.findChild(parentRef))) {
      // Link ref into the parent's child list

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            lucclaes Luc Claes
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment