[NET-289] StackOverflowError in Threader

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0
• Component/s: NNTP
• Assignee: Unassigned
• Reporter: Luc Claes
• Created: 11/Aug/09 09:36
• Updated: 04/Jun/11 19:26
• Resolved: 27/Feb/11 03:29

Description

The loop detection code in Threader.buildContainer() is currently:
// Link references together in the order they appear in the References: header,
// IF they dont have a have a parent already &&
// IF it will not cause a circular reference
if ((parentRef != null)
&& (ref.parent == null)
&& (parentRef != ref)
&& !(parentRef.findChild(ref))) {
// Link ref into the parent's child list
Deep circular references where 'parentRef' is already a child of 'ref' and ref is the root container are possible.
The test should be:
if ((parentRef != null)
&& (ref.parent == null)
&& (parentRef != ref)
&& !(ref.findChild(parentRef))) {
// Link ref into the parent's child list