Uploaded image for project: 'Commons Net'
  1. Commons Net
  2. NET-269

Remove semi-redundant check in SubnetUtils.calculate()

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 3.0
    • Component/s: None
    • Labels:
      None

      Description

      Remove semi-redundant check in SubnetUtils.calculate():

      As far as I can tell, the line

      rangeCheck(pop(netmask),0, NBITS);

      in the calculate method can never fail the NBITS max bound, as the code has already checked for NBITS-1.

      It will trap a mask with 0 bits - but then why not reject that earlier when checking cidrPart?

      Seems wasteful to create pack and unpack the mask just to check for 0.

      It's also confusing to reject 32 bits before creating the mask, and then "allow" it later.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sebb@apache.org Sebb
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: