[NET-236] method SubnetUtils.SubnetInfo.isInRange(addr) returns incorrect result

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.2
• Assignee: Unassigned
• Reporter: Pasha Arājums
• Created: 29/Oct/08 15:07
• Updated: 15/Oct/10 09:20
• Resolved: 05/Feb/09 01:11

Description

current implementation failing to check low limit:

private boolean isInRange(int address)      { return ((address-low()) <= (high()-low())); }

suggested fix:

private boolean isInRange(int address)      { 
    normal = address-low();
    return (normal>=0 && (normal <= (high()-low())));
}

Issue Links

• is duplicated by: NET-260 SubnetUtils.SubnetInfo.isInRange(...) returns incorrect values