Uploaded image for project: 'Commons Net'
  1. Commons Net
  2. NET-188

FTPClient#listFiles returns null element when file's timestamp is "02/29"

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.4
    • 1.5, 2.0
    • None
    • None

    Description

      This issue has same cause as VALIDATOR-221.
      org.apache.commons.net.ftp.parser.FTPTimestampParserImpl#parseTimestamp throws ParseException with timestampStr = "Feb 29 11:22".

      FTP Server status:

      [root@localhost test-commonsnet]# pwd
/tmp/test-commonsnet
[root@localhost test-commonsnet]# ls -l
total 0
-rw-r--r--  1 root root 0 Dec 19  2006 aaa.txt
-rw-r--r--  1 root root 0 Feb 29 11:22 bbb.txt

      test code:

      public void testCommonsNetLeapDay() throws Exception {
    final FTPClient ftp = new FTPClient();
    ftp.connect(host);
    ftp.login(user, password);
    final FTPFile[] listFiles = ftp.listFiles("/tmp/test-commonsnet");
    for (int i = 0; i < listFiles.length; i++) {
        System.out.println("[" + i + "] " + listFiles[i]);
    }
    ftp.disconnect();
}

      results bellow.

      [0] -rw-r--r--    1 0        0               0 Dec 18  2006 aaa.txt
[1] null

      Second element(bbb.txt) should not be null.

      Attachments

        1. commons-net-ftp-date-parser-feb29.patch
          1 kB
          Ingo Weinhold
        2. DstParseTest.java
          0.5 kB
          Brian Phillips
        3. FTPTimestampParserLeap.patch
          4 kB
          Sebb
        4. jan01.patch
          0.7 kB
          Martin Oberhuber
        5. FTPTimestampParserImpl.patch
          5 kB
          Andre Sudhoff

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. NET-198 FTPTimestampParserImpl#parseTimeStamp() is not fully testable

          • Major - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. NET-199 FTPClient returns a FTPFile list with null element.

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. NET-209 FTPClient.listFiles can't parse files which modified on (leap-year's)2/29.

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. NET-190 [FTP Client] Not listing files with 'invalid' date

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. NET-193 FTP throw NullPointerException when enountering 02-29-2008 (leap year bug)

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. NET-224 NullPointerException if in ftp-directory are files with creation date Feb 29 current year (Problem of leap year)

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. NET-191 date parsing in the FTP client doesn't work for 29th Feb (leap years)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. HADOOP-8127 FTPFileSystem is broken when a file is modified on 02/29

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. NET-83 [net] FTP timestamp: year recognition

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. NET-212 FTP short date parsing - how to handle future dates

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. NET-205 Allow FTPFile entries to be generated even if date parsing fails

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. VFS-201 FTP is failing by saying "File doesn't exist" even the file exists and a valid file.

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. NET-211 setLenient() does not work across a year boundary

          • Major - Major loss of function.
          • Closed

          Activity

            People

              Unassigned Unassigned
              manhole HONMA Hirotaka
              Votes:
              32 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: