[NET-188] FTPClient#listFiles returns null element when file's timestamp is "02/29"

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 1.5, 2.0
• Assignee: Unassigned
• Reporter: HONMA Hirotaka
• Created: 25/Feb/08 10:22
• Updated: 01/Mar/12 10:59
• Resolved: 15/May/08 22:02

Description

This issue has same cause as VALIDATOR-221.
org.apache.commons.net.ftp.parser.FTPTimestampParserImpl#parseTimestamp throws ParseException with timestampStr = "Feb 29 11:22".

FTP Server status:

[root@localhost test-commonsnet]# pwd
/tmp/test-commonsnet
[root@localhost test-commonsnet]# ls -l
total 0
-rw-r--r--  1 root root 0 Dec 19  2006 aaa.txt
-rw-r--r--  1 root root 0 Feb 29 11:22 bbb.txt

test code:

public void testCommonsNetLeapDay() throws Exception {
    final FTPClient ftp = new FTPClient();
    ftp.connect(host);
    ftp.login(user, password);
    final FTPFile[] listFiles = ftp.listFiles("/tmp/test-commonsnet");
    for (int i = 0; i < listFiles.length; i++) {
        System.out.println("[" + i + "] " + listFiles[i]);
    }
    ftp.disconnect();
}

results bellow.

[0] -rw-r--r--    1 0        0               0 Dec 18  2006 aaa.txt
[1] null

Second element(bbb.txt) should not be null.

Issue Links

• is blocked by: NET-198 FTPTimestampParserImpl#parseTimeStamp() is not fully testable
• is duplicated by: NET-199 FTPClient returns a FTPFile list with null element.
• is duplicated by: NET-209 FTPClient.listFiles can't parse files which modified on (leap-year's)2/29.
• is duplicated by: NET-190 [FTP Client] Not listing files with 'invalid' date
• is duplicated by: NET-193 FTP throw NullPointerException when enountering 02-29-2008 (leap year bug)
• is duplicated by: NET-224 NullPointerException if in ftp-directory are files with creation date Feb 29 current year (Problem of leap year)
• is duplicated by: NET-191 date parsing in the FTP client doesn't work for 29th Feb (leap years)
• is related to: HADOOP-8127 FTPFileSystem is broken when a file is modified on 02/29
• is related to: NET-83 [net] FTP timestamp: year recognition
• is related to: NET-212 FTP short date parsing - how to handle future dates
• is related to: NET-205 Allow FTPFile entries to be generated even if date parsing fails
• relates to: VFS-201 FTP is failing by saying "File doesn't exist" even the file exists and a valid file.
• relates to: NET-211 setLenient() does not work across a year boundary