[NET-158] login in FTPClient does not always read the complete server response

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Gilles Gaillard
• Created: 18/Apr/07 10:35
• Updated: 20/Sep/07 05:31
• Resolved: 06/Jun/07 23:52

Description

When a password is required to connect the FTP server, the implementation of method login in class FTPClient ends with:
return FTPReply.isPositiveCompletion(pass(password))
which returns false for any code >= 300.

However, some servers send a code 451 before returning the code 530 (NOT_LOGGED_IN). Ignoring this addtional answer,
leads to desynch the client with the server, hence leading to unexpected behaviors in next exchanges.

Threfore i propose to replace the above code in the end of the method with:

_replyCode = p_Client.pass(p_Password);
boolean result = FTPReply.isPositiveCompletion(_replyCode);
if (!result && _replyCode==FTPReply.ACTION_ABORTED){
try

{ _replyCode = p_Client.getReply(); }

catch (Exception e)

{ e.printStackTrace(); }

}
return result;