[NEMO-412] Address Sonar Cloud issue for MemoryChunk

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.2
• Labels: pull-request-available
• Assignee: Haeyoon Cho
• Reporter: Haeyoon Cho
• Created: 19/Aug/19 03:17
• Updated: 07/Mar/20 06:35
• Resolved: 19/Aug/19 05:13

Description

In the current MemoryChunk implementation, the checkIndex() function which checks the valid index does not return false which makes the other conditionals meaningless.

This makes it impossible for the MemoryChunk to check whether this chunk is released or not when accessing it using the random access functions that use UNSAFE.

Since IndexOutOfBounds exception is thrown after the MemoryChunk release is checked, the checkIndex() function should be changed to either return true or false.

Issue Links

• is related to: NEMO-388 Off-heap memory management (reuse ByteBuffer)
• links to: GitHub Pull Request #233