[MYRIAD-198] Remove optionals when sane defaults are available

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Myriad 0.2.0
• Fix Version/s: Myriad 0.3.0
• Component/s: Executor, Scheduler
• Labels: easyfix newbie
• Assignee: John Yost
• Reporter: Darin J
• Created: 05/May/16 16:38
• Updated: 26/Feb/19 17:53
• Resolved: 08/Jun/16 17:20

Description

Currently we overuse Optionals in the config and then use an or method in various factories later. In many cases having the configuration return a default when the parameter was specified would create cleaner code. For instance:

Optional<Boolean> getCgroups() {
Optional.fromNullable(cgroups);
}

vs

Boolean getCgroups() {
return cgroups != null ? cgroups : false;
}

Issue Links

• blocks: MYRIAD-283 Prepare for 0.3.0 release