[MYFACES-4657] servletRegistration.getClassName() may be null and cause an NPE

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.1.0-RC1
• Fix Version/s: 5.0.0, 4.1.0-RC2
• Assignee: Volodymyr Siedlecki
• Reporter: Volodymyr Siedlecki
• Created: 27/Mar/24 18:57
• Updated: 26/Apr/24 20:39
• Resolved: 26/Apr/24 20:39

Description

Exception:

Stack Dump = java.lang.NullPointerException: type is null.
at org.apache.myfaces.core.api.shared.lang.Assert.notNull(Assert.java:35)
at org.apache.myfaces.util.lang.ClassUtils.classForName(ClassUtils.java:207)
at org.apache.myfaces.util.lang.ClassUtils.simpleClassForName(ClassUtils.java:258)
at org.apache.myfaces.application.FacesServletMappingUtils.isFacesServlet(FacesServletMappingUtils.java:177)
at org.apache.myfaces.webapp.MyFacesContainerInitializer.checkForFacesServlet(MyFacesContainerInitializer.java:326)
at org.apache.myfaces.webapp.MyFacesContainerInitializer.onStartup(MyFacesContainerInitializer.java:143)

Introduced via https://github.com/apache/myfaces/commit/e7d8521ee9214ff1dce24ed6fc2b8627e6461213

Web.xml Snippet to reproduce:

   <servlet>
        <servlet-name>test.jsp</servlet-name>
        <jsp-file>/test.jsp</jsp-file>
    </servlet>
    <servlet-mapping>
        <servlet-name>test.jsp</servlet-name>
        <url-pattern>/test.jsp</url-pattern>
    </servlet-mapping>

There is no servlet class in this scenario, so the code tries to search for a null class name.

Issue Links

• links to: GitHub Pull Request #688
• links to: GitHub Pull Request #689