[MYFACES-4633] Suspicious Logic when setting BeanManager from JNDI - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.0.1
Fix Version/s: 4.0.2, 4.1.0-RC1
Component/s: None
Labels:
None

Description

Function private BeanManager lookupBeanManagerFromJndi() in FacesInitializerImpl (specifically line 594 of the current version looks incorrect to me.

The logic in the function is:

Try to retrieve beanManager as java:comp/BeanManager in InitialContext
If this succeeds (i.e. beanManager is non-null), try to retrieve beanManager as java:comp/env/BeanManager in InitialContext

The second step should be done if the first attempt to retrieve beanManager fails, not if it succeeds. (If my interpretation is wrong, I think an explanatory comment is warranted here!)