[MYFACES-4590] NullPointerException when PrimeFaces FileUpload used in composite component

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0, 4.0.1
• Fix Version/s: 4.0.1
• Component/s: General
• Environment: primefaces-test project, jakarta branch
• Assignee: Thomas Andraschko
• Reporter: Manuel K
• Created: 08/Mar/23 08:25
• Updated: 12/Jun/23 12:58
• Resolved: 13/Mar/23 16:46

Description

Using the following composite component, an exception occurs upon rendering only on MyFaces but not on Mojarra. Please let me know if this is a PrimeFaces bug instead and I'll open an issue there.

<?xml version="1.0" encoding="UTF-8"?>

<ui:component xmlns="http://www.w3.org/1999/xhtml"
              xmlns:cc="http://xmlns.jcp.org/jsf/composite"
              xmlns:ui="http://xmlns.jcp.org/jsf/facelets"
              xmlns:p="http://primefaces.org/ui"
              xmlns:h="http://xmlns.jcp.org/jsf/html">
    <cc:interface>

        <cc:attribute name="fileUploadListener"
                      required="true"
                      method-signature="void listener(org.primefaces.event.FileUploadEvent)"/>

        <cc:attribute name="update"
                      type="java.lang.String"/>

        <cc:attribute name="allowTypes"
                      default="/.*/"/>
        <cc:attribute name="accept"/>
        <cc:attribute name="fileLimit"
                      default="1"/>
        <cc:attribute name="sizeLimit"/>
        <cc:attribute name="multiple"
                      default="false"/>
    </cc:interface>
    <cc:implementation>
        <div id="#{cc.clientId}">
            <p:fileUpload id="fileUpload"
                          listener="#{cc.attrs.fileUploadListener}"
                          update="#{cc.attrs.update}"
                          fileLimit="#{cc.attrs.fileLimit}"
                          sizeLimit="#{cc.attrs.sizeLimit}"
                          auto="true"
                          accept="#{cc.attrs.accept}"
                          sequential="true"
                          allowTypes="#{cc.attrs.allowTypes}"
                          multiple="#{cc.attrs.multiple}"/>
        </div>
    </cc:implementation>
</ui:component> 

The exception:

Caused by: java.lang.NullPointerException: Cannot invoke "java.lang.Long.longValue()" because the return value of "org.primefaces.component.fileupload.FileUpload.getSizeLimit()" is null
    at org.primefaces.component.fileupload.FileUploadRenderer.encodeScript (FileUploadRenderer.java:127)
    at org.primefaces.component.fileupload.FileUploadRenderer.encodeEnd (FileUploadRenderer.java:79)
    at jakarta.faces.component.UIComponentBase.encodeEnd (UIComponentBase.java:634) 

You can find my reproducer here: https://github.com/mkomko/primefaces-test/tree/file-upload-npe

Thank you very much in advance as always .

Issue Links

• links to: GitHub Pull Request #555