[MYFACES-4559] JsfArtifactProducer(2.3/3.0/2.3-next) and FacesArtifactProducter(4.0) are incorrect for application implicit object

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.10, 2.3-next-M7, 3.0.2, 4.0.0-RC4
• Fix Version/s: 2.3.11, 3.0.3, 2.3-next-M8, 4.0.0-RC5
• Component/s: General
• Assignee: Paul Nicolucci
• Reporter: Paul Nicolucci
• Created: 10/Feb/23 16:02
• Updated: 16/Feb/23 19:12
• Resolved: 11/Feb/23 22:22

Description

JsfArtifactProducer for the application implicit object: https://github.com/apache/myfaces/blob/2.3.x/impl/src/main/java/org/apache/myfaces/cdi/JsfArtifactProducer.java#L51

FacesArtifactProducer for the application implicit object: https://github.com/apache/myfaces/blob/main/impl/src/main/java/org/apache/myfaces/cdi/FacesArtifactProducer.java#L60

These should not be returning the Application object but rather the ExternalContext.getContext() which is what the ApplicationImplicitObject does.

The spec is clear here as well: https://jakarta.ee/specifications/faces/4.0/jakarta-faces-4.0.html#a2830

Issue Links

• links to: GitHub Pull Request #515
• links to: GitHub Pull Request #516
• links to: GitHub Pull Request #517
• links to: GitHub Pull Request #518