Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-4556

LambdaBeanELResolver#getType should return null if the resolved property is read-only

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.0.0-RC4
    • 4.0.0-RC5
    • None
    • None

    Description

      EL 5.0 Spec Change:
      Explicitly document that ELResolver.getType() must return null if either the ELResolver or the resolved property is read-only.

      We do not check if the property is read-only in our overridden method.

      Our code:
      https://github.com/apache/myfaces/blob/main/impl/src/main/java/org/apache/myfaces/el/resolver/LambdaBeanELResolver.java#L47-L58

      This was discovered in our tests as RC4 disabled USE_LAMBDA_METAFACTORY.

      Attachments

        Activity

          volosied Volodymyr Siedlecki added a comment - https://github.com/apache/myfaces/commit/4f96facccb1d81414c94a367a6d7606caa3464e7

          tandraschko Can I assign this to you since this class is your area?  Not sure if you want to update it for this new check or not.  Thanks!

          volosied Volodymyr Siedlecki added a comment - tandraschko Can I assign this to you since this class is your area?  Not sure if you want to update it for this new check or not.  Thanks!

          People

            tandraschko Thomas Andraschko
            volosied Volodymyr Siedlecki
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: