[MYFACES-4375] ResourceLoaderUtils - connection not close for FileURLConnection

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.0.0-RC1, 2.3-next-M3, 2.3-next-M4, 3.0.0, 4.0.0-RC1
• Fix Version/s: 2.3-next-M5, 3.0.0, 4.0.0-RC1, 2.3.8
• Component/s: General
• Assignee: Thomas Andraschko
• Reporter: Milan Siebenbürger
• Created: 18/Jan/21 12:33
• Updated: 19/Jan/21 09:43
• Resolved: 18/Jan/21 14:12

Description

Hello,

we are facing problem with non-closed connection in ResourceLoaderUtils. Since this change (pull request> https://github.com/apache/myfaces/pull/90)
in method ResourceLoaderUtils.getResourceLastModification(URL url) is connection opened, but it is never closed (assuming it is not instance of JarURLConnection, which is closed correctly).

If URLConnection is FileURLConnection (our case), it is not closed, and afterwards file is locked in file system and can't be accessed (for deleting, etc)...

Method ResourceLoaderUtils.getResourceLastModification is called at ResourceImpl:316.

 

Do you have any solution or workaround for this case, or could it be fixed somehow (ie same as JarURLConnection)?

Thanks

Milan Siebenbürger