Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-4371

Resources: set cache-control-header instead of expires-header

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Wish
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 4.0.0-RC1, 3.0.1, 2.3.9, 2.3-next-M6
    • None
    • None

    Description

      https://github.com/apache/myfaces/blob/master/impl/src/main/java/org/apache/myfaces/resource/ResourceImpl.java#L208 currently set´s expires-header.

      IMO it´s today state-of-the-art to set cache-control: max-age=XXX instead of expires for resources which should be cached. And set cache-control: no-cache for resources which should not be cached.

      Details: https://developer.mozilla.org/de/docs/Web/HTTP/Headers/Cache-Control

      This would also simplify code a bit.

      Also opened a mojarra-issue: https://github.com/eclipse-ee4j/mojarra/issues/4800

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            christophs78 Christoph Straßer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment