[MYFACES-4304] dynamic ui:include doesn't always work

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.12, 2.3-next-M1, 2.3.5
• Fix Version/s: 2.2.13, 2.3-next-M1, 2.3.6
• Component/s: General
• Assignee: Thomas Andraschko
• Reporter: Thomas Andraschko
• Created: 15/Oct/19 14:47
• Updated: 21/Nov/19 17:25
• Resolved: 15/Oct/19 19:54

Description

Just run the attached sample

• initially there is "" assigned to the ui:include
• if you open the sidebar via "include 1", a new src is set and the UI updated but the include is not in the view

it seems to happen because of this If:
if (!PhaseId.RESTORE_VIEW.equals(ctx.getFacesContext().getCurrentPhaseId()))
in the IncludeHandler.

Seems that our IncludeHandler is executed to early in RESTORE_VIEW, as the new include is set in the INVOKE_APPLICATION phase.

In both Mojarra and MyFaces VDL#buildView is called 2 times on the POST:
1) in RestoreView
2) in RenderResponse

The difference is, that only Mojarra calls the IncludeHandler in both phases. MyFaces calls it only in RestoreView.