Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-4237

[perf] Performance update when checking for duplicate ids

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.2.12, 2.3.1
    • 2.2.13, 2.3.2
    • JSR-372
    • None

    Description

      In org/apache/myfaces/view/facelets/compiler/CheckDuplicateIdFaceletUtils.java we currently do the following:

      if (existingIds.contains (id)) {
      ....
      }
      

      We can increase performance by doing the following:

      if (!existingIds.add (id)) {
      ....
      }
      

      Attachments

        Activity

          People

            paul.nicolucci Paul Nicolucci
            paul.nicolucci Paul Nicolucci
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: