[MYFACES-4125] Response committed too early due to flush from StateWriter

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.12
• Fix Version/s: 2.2.13, 2.3.0
• Assignee: Eduardo Breijo
• Reporter: Eduardo Breijo
• Created: 19/Jul/17 21:12
• Updated: 25/Jun/20 18:37
• Resolved: 22/Aug/17 18:53

Description

We've found a problem where it seems that MyFaces is flushing output too early in the RENDER_RESPONSE PHASE. As a result the response is committed before we have a chance to handle an error in that phase.

This is because the renderView method from FaceletViewDeclarationLanguage calls writer.endDocument() which ends up calling the flush() method from StateWriter. This commit behavior is different between 2.0 and 2.2. It looks like a flush() was empty on 2.0, and now a call was added, which causes the issue we are seeing.

Here's a sample app:
1) Drive a request: localhost:9080/StateWriter/index.xhtml
2) You should be able to see in the logs that response was committed, so redirect to error.xhtml cannot be performed.