[MYFACES-3902] jsf.js: error handling output improvement

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.3
• Fix Version/s: 2.0.22, 2.1.16, 2.2.4
• Component/s: General
• Environment: Snapshot code 2.2.3 from trunk + Icefaces 4/Primefaces 4 ; Firefox >=18
• Assignee: Unassigned
• Reporter: Krashan Brahmanjara
• Created: 20/Jun/14 18:32
• Updated: 22/Sep/14 15:32
• Resolved: 23/Jun/14 09:44

Description

Myfaces core do not show real javascipt errors.
In _Dom.js there is a catch block in rows 192-203.
Unofortunately I see two errors

• Icefaces js has exceptions without message and description a message is directly a 'e' object. So an error 'invalid property' is printed to console
• development mode is ignored by this catch block, in reverse order checking too because jsf.ajax.getProjectStage() is not initialized

Workaround - because development mode is recognized we can only show an alert

        } catch (e) {
/*
            if(window.console && window.console.error) {
               //not sure if we
               //should use our standard
               //error mechanisms here
               //because in the head appendix
               //method only a console
               //error would be raised as well
                if (e.message) {
                  window.console.error(e.message);
                } else {
                    if (e.description) {
                      window.console.error(e.description);
                    } else {
                      window.console.error(e);
                    }
               }
            }
            if(jsf.ajax.getProjectStage() === "Development") {
*/
				if (e.message) {
				  alert("Error in evaluated javascript:"+ (e.message));
				} else {
					if (e.description) {
					  alert("Error in evaluated javascript:"+ (e.description));
					} else {
					  alert("Error in evaluated javascript:"+ (e));
					}
				}
/*
            }
*/
       } finally {