[MYFACES-3659] Conditional include of scripts and stylesheets

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.6
• Fix Version/s: 2.0.17, 2.1.11
• Environment: MyFaces 2.1.6, Tomahawk20 1.1.11
• Assignee: Leonardo Uribe
• Reporter: dennis hoersch
• Created: 03/Dec/12 14:12
• Updated: 28/Mar/13 15:59
• Resolved: 27/Mar/13 22:59

Description

I am inserting a script 'X.js' dependent on a condition (c:if). The default case is to include it. If I change the underlying value within an action so that the condition evaluates to false, the script is still included. Also after any other following action.

Using F5 in Firefox the page is now rendered without the script.

The script 'X.js' was added to the view root and is never 'forgot' or removed. It is the same if the script is included in a composite component. In that case I even observed that the order of the scripts changes and the script 'X.js' is included before other basic scripts like jQuery on which 'X.js' depends.

---

<h:form id="form">
<c:set var="sessionScope" value="#

{facesContext.externalContext.sessionMap}

" />

<h:commandButton value="deactivate"
rendered="#

{empty sessionScope.__isActive_ or sessionScope.__isActive_}">
<f:setPropertyActionListener target="#{sessionScope.__isActive_}" value="#{false}" />
</h:commandButton>
<h:commandButton value="activate"
rendered="#{not empty sessionScope.__isActive_ and not sessionScope.__isActive_}">
<f:setPropertyActionListener target="#{sessionScope.__isActive_}" value="#{true}" />
</h:commandButton>

<h:commandButton value="do nothing" />

<h:outputScript library="js" name="jQuery.js" target="body" />

<c:if test="#{empty sessionScope.__isActive_ or sessionScope.__isActive_}

">
BLA
<h:outputScript library="js" name="X.js" target="body" />
</c:if>
</h:form>

---

Am I doing something wrong? Is there another (or better) way to include scripts conditionally?

(
If I change 'HtmlOutputScriptHandler' to set the script transient, it works in the first glance, but I don't know the impact...

@Override
public void onComponentPopulated(FaceletContext ctx, UIComponent c, UIComponent parent) {
super.onComponentPopulated(ctx, c, parent);
c.setTransient(true);
}
)