Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.1.9, 2.2.0
    • None
    • JSR-344
    • None

    Description

      Currently we have a few different viewkey generator implementations. Those got added only in 2.1.9. Before that the only had a TicketCounter in each Session.

      The original implementation also had no viewId in the key.
      If you think about it, then it makes no sense at all to add the viewId. Despite it's an int hashCode we have 2 problems which completely trashes the purpose:
      a.) hashCode is not guaranteed to be unique
      b.) the hashCode is always the same for the same view.

      Think about an application with only one xhtml page. In that case the viewId would add no additional info.
      With 4 pages you would only reduce the collision rate to over 25%. Since the application will most times mainly hit by a few entry points like index.html you gain barely anything from adding this information.

      IF we have had problems with any collisions, then we shall add an XorShift random generator instead of the viewId. Leo, I didn't an issue report for such a problem. Do you have any tip for me where I can find that?

      Attachments

        Activity

          People

            struberg Mark Struberg
            struberg Mark Struberg
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: