[MYFACES-3587] Not existing viewId will not be handled

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.8
• Fix Version/s: 2.1.13
• Component/s: General
• Environment: Jetty/Tomcat, JUEL, CODI, ExtVal
• Assignee: Leonardo Uribe
• Reporter: Thomas Andraschko
• Created: 25/Jul/12 15:58
• Updated: 22/Oct/13 16:01
• Resolved: 17/Oct/13 15:28

Description

If i call a page, which does not exist, following exceptions occurs: Cannot reset buffer after response has been committed.

After digging deeper into this problem, i found out that getViewHandlerSupport()#calculateViewId returns null and the JspViewDeclarationLanguageStrategy will be used ->

Cannot reset buffer after response has been committed.

occurs.

I added a null check for the logicalViewId in RestoreViewExecutor#execute to call HttpServletResponse#sendError.

It does not work as expected because it just renders the errorPage and no redirect will be done.

Why there is not such null check?

Is it possible to add this check and redirect to the web.xml defined 404 or common error page? Or should it use the ErrorHandler?

Issue Links

• is related to: MYFACES-3223 Use ViewNotFoundException in org.apache.myfaces.view.facelets.impl.DefaultFaceletFactory.resolveURL