Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-3576

[perf] use get() over eval() for UIViewRoot.getViewId()

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.15, 2.1.9
    • Component/s: JSR-314
    • Labels:
      None

      Description

      Checking some code I saw this line:

      public String getViewId()

      { return (String) getStateHelper().eval(PropertyKeys.viewId); }

      A viewId can never be a ValueExpression! The viewId is a value that identifies the view in a unique way and it is set according to the rules of the spec. It is possible to change the line and use get() instead.

        Attachments

          Activity

            People

            • Assignee:
              lu4242 Leonardo Uribe
              Reporter:
              lu4242 Leonardo Uribe

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment