Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-3576

[perf] use get() over eval() for UIViewRoot.getViewId()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 2.0.15, 2.1.9
    • JSR-314
    • None

    Description

      Checking some code I saw this line:

      public String getViewId()

      { return (String) getStateHelper().eval(PropertyKeys.viewId); }

      A viewId can never be a ValueExpression! The viewId is a value that identifies the view in a unique way and it is set according to the rules of the spec. It is possible to change the line and use get() instead.

      Attachments

        Activity

          People

            lu4242 Leonardo Uribe
            lu4242 Leonardo Uribe
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: