[MYFACES-3489] ExternalContextUtils doesn't check PORTLET_20_SUPPORTED correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.6
• Fix Version/s: 2.0.13, 2.1.7
• Component/s: Portlet_Support
• Environment: WebSphere 7 Portal + myfaces 2.1.6
• Assignee: Leonardo Uribe
• Reporter: Greg Dick
• Created: 05/Mar/12 22:24
• Updated: 03/Apr/12 18:39
• Resolved: 06/Mar/12 03:08

Description

The code shown in
https://issues.apache.org/jira/browse/MYFACES-3375

sets the static initialization variable "portlet20Supported" properly, and the static final boolean _PORTLET_20_SUPPORTED has the correct value, but the code at line 129 doesn't properly check the flag to identify the request type.

if(_PORTLET_10_SUPPORTED)

should be:

if(_PORTLET_10_SUPPORTED || _PORTLET_20_SUPPORTED)

In WebSphere portal environments, the existing code doesn't property identify button clicks as Action events.