[MYFACES-3475] [perf] Improve performance of HtmlResponseWriterImpl constructor

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.0.12, 2.1.6
• Fix Version/s: 2.0.13, 2.1.7
• Assignee: Martin Kočí
• Reporter: Martin Kočí
• Created: 24/Feb/12 20:07
• Updated: 03/Apr/12 18:39
• Resolved: 02/Mar/12 17:15

Description

HtmlResponseWriterImpl is a very light object created many times. But its constructor uses a memory intensive test if character encoding is valid:

// validates the encoding, it will throw an UnsupportedEncodingException if the encoding is invalid
try

{ new String("myfaces".getBytes(), characterEncoding); }

catch (UnsupportedEncodingException e)

{ throw new IllegalArgumentException("Unsupported encoding: "+characterEncoding); }

this code is number 1. of byte [] allocations in my tests.

We can probably remove this check entirely: a exception will be thrown a few moments later if encoding is not supported

Review other code in constructor too - it must be fast as possible.