Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.13, 2.1.7
    • Component/s: JSR-314
    • Labels:
      None
    • Environment:
      myfaces core trunk

      Description

      see MYFACES-3130 for details

      1. FaceletViewDeclarationLanguage.patch
        2 kB
        Martin Kočí
      2. UIViewRoot.patch
        4 kB
        Martin Kočí
      3. UIData.patch
        0.9 kB
        Martin Kočí
      4. UIComponentBase.patch
        3 kB
        Martin Kočí
      5. RenderResponseExecutor.patch
        2 kB
        Martin Kočí
      6. PartialVisitContext.patch
        3 kB
        Martin Kočí
      7. HtmlRendererUtils.patch
        1 kB
        Martin Kočí
      8. HtmlFormatRenderer.patch
        0.9 kB
        Martin Kočí
      9. HtmlAjaxBehaviorRenderer.patch
        3 kB
        Martin Kočí
      10. _DeltaList2.patch
        0.8 kB
        Martin Kočí
      11. _DeltaList.patch
        0.7 kB
        Martin Kočí
      12. _ComponentChildrenList.patch
        0.8 kB
        Martin Kočí
      13. ApplicationImpl.patch
        1 kB
        Martin Kočí

        Activity

        Martin Kočí created issue -
        Martin Kočí made changes -
        Field Original Value New Value
        Component/s JSR-314 [ 12312453 ]
        Martin Kočí made changes -
        Attachment ApplicationImpl.patch [ 12514862 ]
        Attachment _ComponentChildrenList.patch [ 12514863 ]
        Attachment _DeltaList.patch [ 12514864 ]
        Attachment _DeltaList2.patch [ 12514865 ]
        Attachment HtmlAjaxBehaviorRenderer.patch [ 12514866 ]
        Attachment HtmlFormatRenderer.patch [ 12514867 ]
        Attachment HtmlRendererUtils.patch [ 12514868 ]
        Attachment PartialVisitContext.patch [ 12514869 ]
        Attachment RenderResponseExecutor.patch [ 12514870 ]
        Attachment UIComponentBase.patch [ 12514871 ]
        Attachment UIData.patch [ 12514872 ]
        Attachment UIViewRoot.patch [ 12514873 ]
        Martin Kočí made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Martin Kočí made changes -
        Attachment FaceletViewDeclarationLanguage.patch [ 12514878 ]
        Hide
        Leonardo Uribe added a comment -

        I checked the patches and I commit almost all. I let these ones out:

        • _DeltaList2 : that class will replace _DeltaList, but needs some checking first. I'll apply it later when the change is complete.
        • ApplicationImpl : An iterator is supposed to be used per thread unless it will be empty. The patch stores the iterator at application scope, so it could break on concurrency.
        • UIViewRoot : I only applied the optimization related to Events. I prefer let the other code with an iterator, because the alternative makes the code difficult to read, and that part was specially very difficult to tune.
        Show
        Leonardo Uribe added a comment - I checked the patches and I commit almost all. I let these ones out: _DeltaList2 : that class will replace _DeltaList, but needs some checking first. I'll apply it later when the change is complete. ApplicationImpl : An iterator is supposed to be used per thread unless it will be empty. The patch stores the iterator at application scope, so it could break on concurrency. UIViewRoot : I only applied the optimization related to Events. I prefer let the other code with an iterator, because the alternative makes the code difficult to read, and that part was specially very difficult to tune.
        Leonardo Uribe made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 2.0.13 [ 12319847 ]
        Fix Version/s 2.1.7 [ 12319845 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        33m 46s 1 Martin Kočí 16/Feb/12 20:31
        Patch Available Patch Available Resolved Resolved
        14d 22h 1m 1 Leonardo Uribe 02/Mar/12 18:33
        Resolved Resolved Closed Closed
        32d 5m 1 Leonardo Uribe 03/Apr/12 19:39

          People

          • Assignee:
            Martin Kočí
            Reporter:
            Martin Kočí
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development