[MYFACES-3448] UISelectOne.validateValue(...) optimised & refactored

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.5
• Fix Version/s: 2.0.13, 2.1.7
• Component/s: General
• Assignee: Leonardo Uribe
• Reporter: David Law
• Created: 14/Jan/12 13:44
• Updated: 03/Apr/12 18:39
• Resolved: 02/Mar/12 19:14

Description

The UISelectOne.validateValue(...) code is not particularly human-readable to say the least.
Also, in the case of a match(the norm) the method this.isRequired() is called twice if it returns false.
Patch attached. (100% tested for all permutations of match, isRequired & NoSelection)