MyFaces Core
  1. MyFaces Core
  2. MYFACES-3266

[perf] [concurrency] check correct logger creation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.12, 2.1.6
    • Component/s: None
    • Labels:
      None

      Description

      <BLOCKED>java.util.logging.Logger.getLogger(String)
      javax.faces.component.UIViewRoot.<init>()

      problem is that has non-static logger and logger is requested in every view init. For a class (static) method, the monitor associated with the Class object for the method's class is used.

      Check myfaces code base for this usage.

        Activity

        Martin Kočí created issue -
        Leonardo Uribe made changes -
        Field Original Value New Value
        Attachment MYFACES-3266-1.patch [ 12510303 ]
        Leonardo Uribe made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Leonardo Uribe added a comment -

        Attached patch with proposed solution. The idea is call it only when it is necessary. If no objections I'll commit this code soon.

        Show
        Leonardo Uribe added a comment - Attached patch with proposed solution. The idea is call it only when it is necessary. If no objections I'll commit this code soon.
        Leonardo Uribe made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Martin Kočí [ markoc50 ] Leonardo Uribe [ lu4242 ]
        Fix Version/s 2.0.12 [ 12319175 ]
        Fix Version/s 2.1.6 [ 12319173 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        159d 8h 28m 1 Leonardo Uribe 12/Jan/12 02:59
        Patch Available Patch Available Resolved Resolved
        4d 15h 29m 1 Leonardo Uribe 16/Jan/12 18:28
        Resolved Resolved Closed Closed
        21d 4h 53m 1 Leonardo Uribe 06/Feb/12 23:22

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Martin Kočí
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development